[Bug 198882] Review Request: perl-POE-Component-IRC

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-POE-Component-IRC


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198882


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-07-21 00:24 EST -------
For some reason I had to remove the conditional bits from %check in order to get
this to build or I'd get this:

RPM build errors:
    /builddir/build/SPECS/perl-POE-Component-IRC.spec:58: parseExpressionBoolean
returns -1

and the the entire file list would be ignored, causing the build to fail.  Not
sure what's up here; I thought your syntax was correct.  Anyway, it's simple
remove it to get through the buildsys, or investigate some way to make it work
and it shouldn't hold up the package.

Review:
* source files match upstream:
   e57f2fbcce0aecf07062b8bf83b7bd96  POE-Component-IRC-4.96.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is unnecessary)
* Compiler flags are appropriate (none for noarch package)
* %clean is present.
X package builds in mock (development, x86_64) (needs above fix)
* rpmlint is silent.
* noarch package; no debuginfo.
* final provides and requires are sane:
   perl(POE::Component::IRC) = 4.96
   perl(POE::Component::IRC::Common) = 4.86
   perl(POE::Component::IRC::Constants)
   perl(POE::Component::IRC::Pipeline) = 0.01
   perl(POE::Component::IRC::Plugin) = 0.08
   perl(POE::Component::IRC::Plugin::BotAddressed)
   perl(POE::Component::IRC::Plugin::BotTraffic)
   perl(POE::Component::IRC::Plugin::CTCP) = 1.0
   perl(POE::Component::IRC::Plugin::Connector)
   perl(POE::Component::IRC::Plugin::Console)
   perl(POE::Component::IRC::Plugin::ISupport) = 0.52
   perl(POE::Component::IRC::Plugin::NickReclaim) = 1.0
   perl(POE::Component::IRC::Plugin::PlugMan)
   perl(POE::Component::IRC::Plugin::Proxy)
   perl(POE::Component::IRC::Plugin::Whois) = 0.02
   perl(POE::Component::IRC::Projects) = 0.01
   perl(POE::Component::IRC::Qnet) = 1.3
   perl(POE::Component::IRC::Qnet::State) = 1.5
   perl(POE::Component::IRC::State) = 1.9
   perl(POE::Component::IRC::Test::Harness) = 0.4
   perl(POE::Component::IRC::Test::Plugin)
   perl(POE::Filter::CTCP)
   perl(POE::Filter::IRC)
   perl(POE::Filter::IRC::Compat) = 1.0
   perl-POE-Component-IRC = 4.96-1.fc6
  =
   perl >= 0:5.006
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Data::Dumper)
   perl(Exporter)
   perl(File::Basename)
   perl(POE)
   perl(POE::Component::IRC) >= 4.5
   perl(POE::Component::IRC::Common)
   perl(POE::Component::IRC::Constants)
   perl(POE::Component::IRC::Pipeline)
   perl(POE::Component::IRC::Plugin)
   perl(POE::Component::IRC::Plugin::ISupport)
   perl(POE::Component::IRC::Plugin::Whois)
   perl(POE::Filter::CTCP)
   perl(POE::Filter::IRC)
   perl(POE::Filter::IRC::Compat)
   perl(POE::Filter::IRCD)
   perl(POSIX)
   perl(Socket)
   perl(Symbol)
   perl(base)
   perl(constant)
   perl(strict)
   perl(vars)
   perl(warnings)
* %check is present but tests are necessarily disabled.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.