[Bug 199784] Review Request: psycopg2 - A PostgreSQL database adapter for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: psycopg2 - A PostgreSQL database adapter for Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199784





------- Additional Comments From devrim at commandprompt.com  2006-07-21 20:06 EST -------
Hi,

First of all: Thanks for the comments:
(In reply to comment #1)
> I'm not experienced in reviewing packages and I'm not official reviewer, but
> first thing that came to my head is that you don't need to specify python
> version in release number. Packaging Naming Guidelines doesn't say anything
> about that. Also, python version will be assigned to package by python
> dependency.

Hmm. Ok. I removed the relevant part.

> More important thing is wrong name of package. According to Package Naming
> Guidelines package' name should be python-psycopg2. Take a look on it:
> http://fedoraproject.org/wiki/Packaging/NamingGuidelines

Great. That was a last-minute change I've applied before submitting. I reverted it.

> And the last thing: mock builds fail. It looks like adding dos2unix
> BuildRequires fixes this problem.

Good catch. dos2unix was again a last-minute add to the spec. I've committed
this change, too.

I'll write URLS for the new SRPM and spec file link as a new comment.

Regards, Devrim

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.