[Bug 199679] Review Request: pgpool - Connection pooling/replication server for PostgreSQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pgpool - Connection pooling/replication server for PostgreSQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199679





------- Additional Comments From mr.ecik at gmail.com  2006-07-22 11:41 EST -------
I have done quick review and I noticed a few things you have to do:

 * add %{?dist} tag to release number. http://fedoraproject.org/wiki/Packaging/
DistTag
 * Source0 have to be URL, actually it is unable to check if archive in src.rpm
and archive on .net checksums is matching. For more information read:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines#head-
2f03bba0a9f05b2ac0128eb1d70b1e3ce9f9dc40
 * you should use %configure macro instead of hardcoding it
 * Packaging Guidelines suggest to use make %{?_smp_flags} instead of 'make'
alone
 * in %install section you forgot to write $RPM_BUILD_ROOT before %{_mandir}
 * man file has wrong permissions (0744), you have to change it to 644 typing:
%attr(0644, root, root) %{_mandir}/man8/* in %section

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.