[Bug 199679] Review Request: pgpool - Connection pooling/replication server for PostgreSQL
bugzilla at redhat.com
bugzilla at redhat.com
Sun Jul 23 12:32:23 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: pgpool - Connection pooling/replication server for PostgreSQL
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199679
------- Additional Comments From devrim at commandprompt.com 2006-07-23 08:23 EST -------
H(In reply to comment #1)
> I have done quick reviewi,
and I noticed a few things you have to do:
>
> * add %{?dist} tag to release number.
Done.
> * Source0 have to be URL, actually it is unable to check if archive in
src.rpm and archive on .net checksums is matching.
Done.
> * you should use %configure macro instead of hardcoding it
Done.
> * Packaging Guidelines suggest to use make %{?_smp_flags} instead of 'make'
> alone
Done.
> * in %install section you forgot to write $RPM_BUILD_ROOT before %{_mandir}
> * man file has wrong permissions (0744), you have to change it to 644 typing:
> %attr(0644, root, root) %{_mandir}/man8/* in %section
I solved this during %install.
I'll post the URLs as another comment. Thanks a lot.
Regards, Devrim
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list