[Bug 199573] Review Request: BackupPC - high-performance backup system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: BackupPC - high-performance backup system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199573





------- Additional Comments From dennis at ausil.us  2006-07-23 14:45 EST -------
  package meets naming and packaging guidelines.
 specfile is properly named, is cleanly written and uses macros consistently.
 build root is correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 license field matches the actual license.
 license is open source-compatible. GPL License text included in package.
 source files match upstream:
[dennis at daedalus SPECS]$ sha1sum BackupPC-2.1.2.tar.gz
9f99e201fbf6bbd016c19007e5fb4072d77312c7  BackupPC-2.1.2.tar.gz
[dennis at daedalus SPECS]$ sha1sum ../SOURCES/BackupPC-2.1.2.tar.gz
9f99e201fbf6bbd016c19007e5fb4072d77312c7  ../SOURCES/BackupPC-2.1.2.tar.gz

 latest version is being packaged.
 BuildRequires are proper.
 package builds in mock ( ).
 rpmlint
[dennis at daedalus SPECS]$ 
rpmlint /var/lib/mock/aurora-2-sparc-extras/result/BackupPC-2.1.2-2.noarch.rpm
E: BackupPC non-executable-script /usr/share/BackupPC/lib/BackupPC/Lang/nl.pm 
0444
E: BackupPC non-standard-uid /var/lib/BackupPC/cpool backuppc
E: BackupPC non-standard-dir-perm /var/lib/BackupPC/cpool 0750
E: BackupPC non-standard-uid /etc/BackupPC backuppc
E: BackupPC non-standard-gid /etc/BackupPC backuppc
E: BackupPC non-standard-dir-perm /etc/BackupPC 0750
E: BackupPC non-standard-uid /var/lib/BackupPC/pc backuppc
E: BackupPC non-standard-dir-perm /var/lib/BackupPC/pc 0750
E: BackupPC non-standard-uid /etc/BackupPC/hosts backuppc
E: BackupPC non-standard-gid /etc/BackupPC/hosts backuppc
E: BackupPC non-standard-uid /usr/share/BackupPC/sbin/BackupPC_Admin backuppc
E: BackupPC non-standard-gid /usr/share/BackupPC/sbin/BackupPC_Admin apache
E: BackupPC setuid-binary /usr/share/BackupPC/sbin/BackupPC_Admin backuppc 
04750
E: BackupPC 
non-standard-executable-perm /usr/share/BackupPC/sbin/BackupPC_Admin 04750
E: BackupPC non-standard-uid /var/lib/BackupPC/conf backuppc
W: BackupPC dangling-symlink /var/lib/BackupPC/conf /etc/BackupPC/
E: BackupPC non-executable-script /usr/share/BackupPC/lib/BackupPC/Lang/es.pm 
0444
E: BackupPC non-standard-uid /etc/BackupPC/config.pl backuppc
E: BackupPC non-standard-gid /etc/BackupPC/config.pl backuppc
E: BackupPC non-readable /etc/BackupPC/config.pl 0640
E: BackupPC non-executable-script /usr/share/BackupPC/lib/BackupPC/Lang/it.pm 
0444
E: BackupPC non-executable-script /usr/share/BackupPC/lib/BackupPC/Lang/de.pm 
0444
E: BackupPC non-standard-uid /var/lib/BackupPC/pool backuppc
E: BackupPC non-standard-dir-perm /var/lib/BackupPC/pool 0750
E: BackupPC non-executable-script /usr/share/BackupPC/lib/BackupPC/Lang/en.pm 
0444
E: BackupPC non-standard-uid /var/lib/BackupPC/log backuppc
E: BackupPC non-standard-uid /var/lib/BackupPC/trash backuppc
E: BackupPC non-standard-dir-perm /var/lib/BackupPC/trash 0750
E: BackupPC non-standard-uid /var/log/BackupPC backuppc
E: BackupPC non-standard-gid /var/log/BackupPC backuppc
E: BackupPC non-standard-uid /var/lib/BackupPC backuppc
E: BackupPC non-standard-dir-perm /var/lib/BackupPC 0750
E: BackupPC non-executable-script /usr/share/BackupPC/lib/BackupPC/Lang/fr.pm 
0444
E: BackupPC incoherent-subsys /etc/rc.d/init.d/BackupPC backuppc
W: BackupPC incoherent-init-script-name BackupPC
 
 final provides and requires are sane:
[dennis at daedalus SPECS]$ rpm -q --requires BackupPC
/bin/sh
/bin/sh
/bin/sh
/bin/sh
/bin/sh
/sbin/chkconfig
/sbin/chkconfig
/sbin/service
/sbin/service
/sbin/service
/usr/bin/perl
/usr/sbin/useradd
/usr/sbin/usermod
config(BackupPC) = 2.1.2-2
httpd
perl(Archive::Zip)
perl(BackupPC::Attrib)
perl(BackupPC::CGI::Lib)
perl(BackupPC::FileZIO)
perl(BackupPC::Lib)
perl(BackupPC::PoolWrite)
perl(BackupPC::View)
perl(BackupPC::Xfer::Archive)
perl(BackupPC::Xfer::Rsync)
perl(BackupPC::Xfer::RsyncDigest)
perl(BackupPC::Xfer::RsyncFileIO)
perl(BackupPC::Xfer::Smb)
perl(BackupPC::Xfer::Tar)
perl(BackupPC::Zip::FileMember)
perl(CGI)
perl(CGI::Carp)
perl(Carp)
perl(Compress::Zlib)
perl(Config)
perl(Cwd)
perl(Data::Dumper)
perl(Digest::MD5)
perl(DirHandle)
perl(Exporter)
perl(Fcntl)
perl(File::Compare)
perl(File::Copy)
perl(File::Find)
perl(File::Path)
perl(File::RsyncP)
perl(Getopt::Std)
perl(IO::Handle)
perl(POSIX)
perl(Socket)
perl(constant)
perl(lib)
perl(strict)
perl(vars)
perl-suidperl
[dennis at daedalus SPECS]$ rpm -q --provides BackupPC
config(BackupPC) = 2.1.2-2
perl(BackupPC::Attrib)
perl(BackupPC::CGI::AdminOptions)
perl(BackupPC::CGI::Archive)
perl(BackupPC::CGI::ArchiveInfo)
perl(BackupPC::CGI::Browse)
perl(BackupPC::CGI::DirHistory)
perl(BackupPC::CGI::EmailSummary)
perl(BackupPC::CGI::GeneralInfo)
perl(BackupPC::CGI::HostInfo)
perl(BackupPC::CGI::LOGlist)
perl(BackupPC::CGI::Lib)
perl(BackupPC::CGI::Queue)
perl(BackupPC::CGI::ReloadServer)
perl(BackupPC::CGI::Restore)
perl(BackupPC::CGI::RestoreFile)
perl(BackupPC::CGI::RestoreInfo)
perl(BackupPC::CGI::StartServer)
perl(BackupPC::CGI::StartStopBackup)
perl(BackupPC::CGI::StopServer)
perl(BackupPC::CGI::Summary)
perl(BackupPC::CGI::View)
perl(BackupPC::FileZIO)
perl(BackupPC::Lib)
perl(BackupPC::PoolWrite)
perl(BackupPC::View)
perl(BackupPC::Xfer::Archive)
perl(BackupPC::Xfer::Rsync)
perl(BackupPC::Xfer::RsyncDigest)
perl(BackupPC::Xfer::RsyncFileIO)
perl(BackupPC::Xfer::Smb)
perl(BackupPC::Xfer::Tar)
perl(BackupPC::Zip::FileMember)
BackupPC = 2.1.2-2

 no shared libraries are present.
 package is not relocatable.
 owns the directories it creates.
 doesn't own any directories it shouldn't.
 no duplicates in %files.
 file permissions are appropriate.
 %clean is present.

 scriptlets present and correct
 code, not content.
 documentation is small, so no -docs subpackage is necessary.
 %docs are not necessary for the proper functioning of the package.
 no headers.
 no pkgconfig files.
 no libtool .la droppings.
 not a GUI app.

Non Fatal errors 
 dist tag is not present.

as for the rpmlint warnings errors  i think that  due to the nature of this 
app they are needed to be as they are.  It provides a layer of seperation from 
the backup app and the system.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.