[Bug 199192] Review Request: kadu - Gadu-Gadu client for online messaging

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kadu - Gadu-Gadu client for online messaging


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192


rdieter at math.unl.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rdieter at math.unl.edu




------- Additional Comments From rdieter at math.unl.edu  2006-07-24 11:33 EST -------
A few comments:
* Requires: qt
is superfluous.

* Since you used the macro:
%define		_themesdir	%{_datadir}/%{name}/themes
It appears that %{_datadir}/%{name} ends up being unowned.

* -devel includes:
%{_libdir}/libgadu.a
The packaging guidelines mandate (recommend strongly?) that static libs be 
omitted.  That is, unless you can make a (strong) case to justify its 
inclusion.

* Personally, I'd say making that many subpkgs is nutty (and a maintainance 
nightmare), but that's just me. (:

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.