[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627





------- Additional Comments From rdieter at math.unl.edu  2006-07-26 08:19 EST -------
1.  %prep: the rm should come *after* the %setup, else, there's nothing 
there/unpackage yet to delete.

2.  drop hard-coded
Requires: kdelibs

3.  If this is a cvs snapshot prerelease, Release tag should be prefixed with 
0. so use something like this instead:
Release: 0.2.%{cvs_date}cvs%{?dist}

4.  The bit in %build
export QTLIB...
isn't needed anymore to workaround qt bug(s).  The bugs have been fixed.

5.  Drop 
%doc INSTALL
no need for INSTALL instructions here. (:

6.  Since you're installing icons, you should include scriptlets:
%post
touch --no-create %{_datadir}/icons/crystalsvg || :

%postun
touch --no-create %{_datadir}/icons/crystalsvg || :

7. You probably ought to change
%defattr(0644,root,root,0755)
to
%defattr(-,root,root,-)
then you won't need the %attr bits for:
%attr(0755,root,root)%{_bindir}/*

8. Upstream source.  If you're going to be using a cvs checkout, please provide 
a script to (re)generate said source tarball.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.