[Bug 199968] Review Request: xdg-utils - Basic desktop integration functions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xdg-utils - Basic desktop integration functions


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199968


laurent.rineau__fedora_extras at normalesup.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |laurent.rineau__fedora_extra
                   |                            |s at normalesup.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From laurent.rineau__fedora_extras at normalesup.org  2006-07-26 12:59 EST -------
Here is a review. I have voluntarily not read the previous review.

*MUST: rpmlint output on src.rpm 
is "W: xdg-utils mixed-use-of-spaces-and-tabs"
  There is one TAB in the "Name:" tag.
*SHOULD: Naming and version are ok, but you should add the dist tag to the 
release number.
*OK: spec file name
*MUST: packaging guidelines
  -MUST: do not use %makeinstall, but DESTDIR instead (seems that the 20060721 
tarball supports DESTDIR).
*OK: license ok, license file in doc
*OK: legible spec file. I do not understand either the remark of Devrim in 
comment #3
*OK: upstream sources have same md5sum: fde4bf35fc34c58faa562bfb96103eb5
*OK: noarch package
*OK: no locales
*OK: no shared libraries
*OK: correct %files
*OK: permissions
*OK: %clean section

*SHOULD: maybe add a %check section

Summary:
  Rex, please correct the Name: tag, and the %install stuff, and this package 
will be accepted.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.