[Bug 200151] Review Request: perl-POE-Wheel-Null

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-POE-Wheel-Null


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200151


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-07-26 19:55 EST -------
Well, this is pretty simple.  The only comment I have is that the extra bit in
the description is pretty obscure (I'm not a Star Trek fan and had to look it
up, geek cred--) and doesn't seem to come from the description in the package's
documentation.

Review:
* source files match upstream:
   8abee8da7a141aca6c0bff6517ca8497  POE-Wheel-Null-0.01.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is not necessary)
* noarch package; no compiler flags are passed.
* %clean is present.
* package builds in mock (development, x86_64).
* noarch package; no debuginfo.
* rpmlint is silent.
* final provides and requires are sane:
   perl(POE::Wheel::Null) = 0.01
   perl-POE-Wheel-Null = 0.01-0.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(POE)
   perl(base)
   perl(strict)
   perl(vars)
* %check is present and all tests (test?) pass:
   All tests successful.
   Files=1, Tests=1,  0 wallclock secs ( 0.01 cusr +  0.01 csys =  0.02 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
  (Technically the documentation is twice the size of the code, but the whole
package is only 5K.)
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.