[Bug 195255] Review Request: manaworld - 2D mmorpg game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: manaworld - 2D mmorpg game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195255


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |NEXTRELEASE
         AssignedTo|bugzilla-sink at leemhuis.info |hugo at devin.com.br
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-06-14 12:25 EST -------
[reposting comments from original review]
------- Additional Comments From hugo at devin.com.br  2006-06-11 21:08 EST -------
My Review:

MUST (OK)

 * rpmlint does not return any warning/errors (good)
 * Package is named according to Package Naming Guidelines
 * Spec filename matches package base name
 * Package license is open-source compliant
 * License field matches package's license
 * License file (COPYING) is included in %doc
 * Spec file is written in American English
 * Spec file is legible
 * Source file from package matches the upstream source with md5sum:
   b142f603c75819a04ac50d876776e92b  tmw-0.0.19.tar.gz
 * Package compiled and built fine in i386
 * BuildRequires is used well
 * Package does not contain locale files
 * Package does not contain shared library files
 * Package is not relocatable
 * Package owns all directories it creates
 * No duplicate files in %files
 * macro use consistent
 * No -doc subpackage needed
 * %doc contains only files that do not affect application runtime
 * No -devel subpackage needed
 * No pkgconfig files (.pc) needed
 * Package does not contain libtool archives (.la)
 * Desktop file installed with desktop-file-install
 * Package does not own other packages' directories

SHOULD (OK)

 * Scriptlets for icon cache are used in proper way
 * Package installs and runs just fine!


------- Additional Comments From hugo at devin.com.br  2006-06-11 22:53 EST -------
APPROVED

------- Additional Comments From wart at kobold.org  2006-06-12 22:17 EST -------
Imported and built on FC-4, FC-5 (devel build queued)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.