[Bug 195015] Review Request: xpa

bugzilla at redhat.com bugzilla at redhat.com
Sat Jun 17 08:32:19 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xpa


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195015


michael at knox.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |michael at knox.net.nz
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From michael at knox.net.nz  2006-06-17 04:24 EST -------
* RPM name is OK
* Source xpa-2.1.6.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of xpa-devel looks OK
* rpmlint of xpa looks OK
* File list of xpa-devel looks OK
* File list of xpa looks OK

I would recommend you just add some white space between the %package devel and
%description devel. Same again for %install and %clean, just improves the flow
and readability of your spec file. 

If you make those changes, I see no reason why I can't approve this package. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list