[Bug 194481] Review Request: eggdrop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eggdrop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194481





------- Additional Comments From michael at knox.net.nz  2006-06-18 20:35 EST -------
Robert. Firstly, I would not "joke" like that in a review. in release 3, the
patch is incorrect. 

Secondly, you should review the package naming guidelines, as it clearly states
in there this:

----

Package Release

In the past, Fedora.us used 0.fdr as a release prefix to identify Fedora.us
packages. In Fedora, this repository "tagging" is unnecessary, and should not be
used. The release number (referred to in some older documentation as a "vepoch")
is how the maintainer marks build revisions, starting from 1. When a minor
change (spec file changed, patch added/removed) occurs, or a package is rebuilt
to use newer headers or libraries, the release number should be incremented. If
a major change (new version of the software being packaged) occurs, the version
number should be changed to reflect the new software version, and the release
number should be reset to 1. 

----

Following this practise is required when a package is accepted in to Extras, a
review should be considered no different. 

Thirdly, you have not updated the changelog in the SPEC to reflect that you have
made a patch to the source. Accurate changelogs are important. 

Lastly, the patch file's name incorrectly represents the change now that you
have added a source code patch to it. 

My suggestion is that you make a eggdrop-1.6.17-4.src.rpm, with a changelog
entry reflecting the new patch and you rename the patch so it does not mislead
other people doing a quick overview as to what the patch is doing. 



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.