[Bug 196003] Review Request: Kmenu-gnome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Kmenu-gnome


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196003





------- Additional Comments From ariszlo at gmail.com  2006-06-22 12:29 EST -------
(In reply to comment #5)
> I've gotta say this one does some absolutely nasty stuff in %post, including
> symlinking icons, and patching xdg menu files, (almost?) all of which could be
> implemented via an alternate icon theme and making a proper xdg menu and using
> $XDG_CONFIG_DIRS.  IMO, definitely a MUSTFIX.

Symlinking the icons is not essential so I don't mind removing it from
kmenu-gnome.spec but I don't see how symlinking _these specific icons_ would be
harmful. It is unlikely that they would ever be included in Bluecurve or Crystal
SVG.

However, patching xdg merge files like /etc/xdg/menus/system-settings.menu is a
must if you put anything into /etc/xdg/menus/applications-merged to suppress a
bug caused by a harmful piece of code found in (almost?) all of the xdg merge
files installed with redhat-menus.

See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196275 for details.

The patch in %post temporarily fixes the bug caused by redhat-menus while the
patch in %preun is a reverse patch to undo what the patch in %post did.

As for making a proper xdg menu and using $XDG_CONFIG_DIRS, I don't understand
how one could do it less intrusively than kmenu-gnome does.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.