[Bug 192889] Review Request: openais standards based cluster framework

bugzilla at redhat.com bugzilla at redhat.com
Thu Jun 1 06:11:49 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openais standards based cluster framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889





------- Additional Comments From sdake at redhat.com  2006-06-01 02:03 EST -------
(In reply to comment #22)
> "man openais_overview" mentions adding a user "ais" to the system. Shouldn't the
> package be doing that?
> 

yes check out the new source rpm I have added the functionality.  Unfortunately
I am not sure which UID to use.  Is there a UID registry maintained for fedora?

> Would it be approriate to do a "/sbin/service openais condrestart" in %post to
> restart the service if it's running when the main package is upgraded?
> 

good suggestion and that has been added.

> Directory ownership looks OK to me now.
> 
> I think %{_libdir}/openais/lib*.so.* should be in the main package, and only
> %{_libdir}/openais/lib*.so should be in the devel package. This would be
> consistent with other packages. If the libs are only needed for the devel
> package, then the /etc/ld.so.conf.d/openais-*.conf file should be in the devel
> package and the scriptlet calls of ldconfig should be in the devel package too.
> 

I don't understand why lib*.so.* should be in main and lib*.so be in devel?  As
an example, consider libevs.

The library is libevs.so.1.0.0.  There are two dynamic links libevs.so.1 and
libevs.so that point to libevs.so.1.0.0.

With your suggestion this would put the real binary library libevs.so.1.0.0 and
one of the links libevs.so.1 into the main package and the link libevs.so into
the devel.  But in fact they are all development libraries.
/etc/ld.so.conf.d should be moved and has been.  You are right about the
scriptlets that call ldconfig.  This was causing a weird bug which I couldn't
figure out until your suggestion.

Thanks you have been a world of help.

Here is the latest
* Thu May 31 2006 Steven Dake <sdake at redhat.com> - 0.76-1.2
- Add user account for AIS applications and authentication.
- Move /etc/ld.so.conf/openais-*.conf to devel package since it is
  only needed there.
- Move ldconfig to devel package.
- Execute condrestart on upgrade

Please find the new files at the following location:
Spec URL: http://developer.osdl.org/dev/openais/SRPM/openais.spec
SRPM URL: http://developer.osdl.org/dev/openais/SRPM/openais-0.76-1.2.src.rpm

Further review and help with the default UID to use and better explination of
the .so packaging conventions would be helpful.

Thanks Paul!
-steve

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list