[Bug 189713] Review Request: gnubg

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnubg


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189713





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-06-05 16:23 EST -------
Hi, just a few quick remarks I take a closer look soon:
* # convert man page from UTF8 to ISO-8859-1
 Actually its the other way around :)
* 
/usr/bin/iconv -f ISO-8859-1 -t UTF8 $RPM_BUILD_ROOT/usr/share/man/man6/gnubg.6
> /tmp/foo
/bin/mv /tmp/foo $RPM_BUILD_ROOT/usr/share/man/man6/gnubg.6

Don't use a file in the global temp dir for this and don't do this in %install
do it in %prep and then use gnubg.6.tmp as tempfile name, what happens when
using the global /tmp dir and another packages which gets build at the same time
does the same? Also by using a fixed name in /tmp you're creating a tempfile
security vulnerability (on the buildsys).

* I see you've put the png ion the 32x32 dir is it (circa) 32x32 pixels? if not
it should probably be in another dir (for example 48x48 or ... see the ones on
your system).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.