[Bug 194594] Review Request: wireshark

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wireshark


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194594


jkeating at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|notting at redhat.com          |jkeating at redhat.com
OtherBugsDependingO|188265                      |188267
              nThis|                            |




------- Additional Comments From jkeating at redhat.com  2006-06-09 14:05 EST -------
Radek, it would be helpful if the spec was linked to outside the srpm, just
makes reviews easier.

NEEDSWORK:
- buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- You need Provides: ethereal to go along with your Obsoletes: for upgrade paths.
- Summary for wireshark-gnome, surely this is for more than just "Red Hat Gnome" ?
- Again, need Provides ethereal-gnome to go along w/ Obsoletes
- tshark -> tethereal link is well above the comment regarding it.
- files in /etc should be marked as config files, unless they are init scripts
- Desktop file present but not installed using desktop-file-install (which would
have a BuildRequires: on destkop-file-utils)

Question:
- If you take out the manual Requires, and let rpmbuild figure it out by soname
requirements, does it do the right thing?  THis is preferred method for Requires.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.