[Bug 191014] Review Request: ganymed

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ganymed


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191014


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |tibbs at math.uh.edu
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-06-11 01:56 EST -------
I was able to fix the debuginfo generation by adding the following to the end of
the %build section:

# Move source files to fix -debuginfo generation.
mv src/* .

It seems the file locations stored in the debug information didn't match the
actual locations of the files, so I just moved them so that they'd be found. 
There are still some errors lile:

cpio: ganymed-ssh2-build209/ch/ethz/ssh2/Connection$1$TimeoutState.java: No such
file or directory

Each of the errors mentions a file with a dollar sign; no such files exist in
the source.

One other thing to note: the page http://fedoraproject.org/wiki/NativeJava,
which I'm taking as the packaging guidelines here, mentions that the %post and
%postun scripts should look like:

if [ -x %{_bindir}/rebuild-gcj-db ]
then
  %{_bindir}/rebuild-gcj-db
fi

I don't really see the difference if the package that provides rebuild-gcj-db is
explicitly kept in with Require(post) and Require(postun), and the way this
package does things is simpler and matches what the core eclipse packages do.

So really the only issues I see are the documentation and the changelog revision
format.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.