[Bug 185531] Review Request: fcron, a task scheduler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fcron, a task scheduler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185531


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |pertusus at free.fr
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From pertusus at free.fr  2006-06-15 11:09 EST -------
We're almost there, still 3 things.

- First calling README the file to read for enabling fcron to start at
boot time is in my opinion misleading, it should be called along
README.rpm or REAME.fedora (et pareil pour le LISEZMOI).

- I have a proposal for the description:

WARNING: fcron isn't started automatically on boot after
installation. You can use system-config-services to enable
autoamtic fcron startup on boot, or use chkconfig as explained
in the %{_docdir}/%{name}-%{version}/REAME.rpm file.

Je te fais confiance pour la traduction en francais...

- it may be nice to explain in README.rpm how to do the same than
with crond/anacron. I believe it goes along installing the crontabs
rpm and call
fcrontab /etc/crontab
each time this file is modified.

Those minor issues may be fixed later.

Full review:
* rpmlint output is
setgid/setuid bits required for the fcron user to send signal to
the fcrond process, and for any user to modify the fcrontabs
as user fcron, and permissions for the fcron user:
E: fcron non-standard-uid /usr/bin/fcrontab fcron
E: fcron non-standard-gid /usr/bin/fcrontab fcron
E: fcron setuid-gid-binary /usr/bin/fcrontab fcron fcron 06755
E: fcron non-standard-executable-perm /usr/bin/fcrontab 06755
E: fcron non-standard-uid /var/spool/fcron fcron
E: fcron non-standard-gid /var/spool/fcron fcron
E: fcron non-standard-dir-perm /var/spool/fcron 0770
E: fcron non-standard-gid /usr/bin/fcronsighup fcron
E: fcron setuid-binary /usr/bin/fcronsighup root 04754
E: fcron non-standard-executable-perm /usr/bin/fcronsighup 04754

Needed to remove the fcron user:
W: fcron dangerous-command-in-%postun userdel

rpmlint bug (reported, fixed in devel):
E: fcron incoherent-subsys /etc/rc.d/init.d/fcron ;

* follows naming guidelines
* licence is GPL and included in %doc
* spec is legible
* md5sum match: 8e5dcb3a646c11294294895954ef0a48
* no duplicate files in %file
* permissions set properly, only doc files in %doc
* own all directories it needs (/var/spool/fcron/)
* no lib included

I'll ask for reviews on the mailing list since this is an important
package with security implication, which could maybe replace
crond/anacron at some point.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.