[Bug 194305] Review Request: gtypist - GNU typing tutor
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jun 16 00:30:43 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gtypist - GNU typing tutor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194305
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-06-15 20:22 EST -------
The only rpmlint warning left is:
W: emacs-gtypist no-documentation
which can be ignored.
Review:
* package meets naming and packaging guidelines.
emacs-gtypist contains lisp files for emacs only.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text included in package.
* source files match upstream:
200d42de9a0070866d88116112370f0a gtypist-2.7.tar.bz2
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint has only ignorable complaints.
* final provides and requires are sane:
emacs-gtypist-2.7-3.fc6.x86_64.rpm
emacs-gtypist = 2.7-3.fc6
=
emacs
gtypist-2.7-3.fc6.x86_64.rpm
gtypist = 2.7-3.fc6
=
/bin/sh
/sbin/install-info
/usr/bin/perl
fortune-mod
libncurses.so.5()(64bit)
perl(Carp)
perl(File::Temp)
perl(Getopt::Std)
perl(strict)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream.
* scriptlets (install-info) are OK.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list