[Bug 185951] Review Request: amsn : msn messenger clone

bugzilla at redhat.com bugzilla at redhat.com
Sun Jun 18 23:04:59 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: amsn : msn messenger clone


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951





------- Additional Comments From wart at kobold.org  2006-06-18 18:56 EST -------
(In reply to comment #23)
> You're also taking ownership of directories (by the looks of it)
> 
> Instead of
> 
> %{_datadir}/amsn/foo/
> 
> use
> 
> %{_datadir}/amsn/foo/*.zip (for example)
> 
> You cannot guarantee that later on someone won't create a plugin which needs to
> be added to the directory "owned" by the package

Except that plugins are stored in %{_datadir}/amsn/plugins.  This plugin dir is
owned by the base package, but not by the -plugins subpackage.  This should be
ok, as future plugins would go into %{_datadir}/amsn/plugins/<foo> and not own
the parent plugins/ directory.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list