[Bug 185951] Review Request: amsn : msn messenger clone

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: amsn : msn messenger clone


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951





------- Additional Comments From sander at hoentjen.eu  2006-06-19 06:10 EST -------
Thank you very much for your comments Paul and Wart.
Paul:
(In reply to comment #23)
I fixed the $RPM_BUILD_ROOT inconsistency. The rest of your comments are already
answered by Wart.
Wart:
(In reply to comment #25)

> * Missing "Requires: mozilla".  I would recommend, however, changing the
>   default browser command from 'mozilla $url' to 'htmlview $url' and
>   adding "Requires: htmlview".  This will launch the url in the
>   user's preferred web browser.
I changed mozilla to htmlview but I am not sure about requiring it. aMSN runs
fine without it, only when you try to open an url it tells you you should check
your preferences. People not having htmlview have chosen for that i guess, since
it is installed by default.
> * Missing "Requires: sox" for /usr/bin/play for playing sounds.
Same as htmlview, aMSN runs fine without sound.
> QUESTIONS
> =========
> * Official upstream sources come from sourceforge.net, but this rc release
>   comes from elsewhere.  Since I know you're one of the upstream developers,
>   I'm not too concerned about this, but it would be better if Source0:
>   pointed to upstream's official download page.
Sorry, I meant to write the reason in my previous comment but forgot. At the
time I had trouble uploading the file to sf, but in the meantime i have done so.
I changed Source0 accordingly. Just be aware that the release is still hidden so
you won't find the file on the project website yet.
> 
> * You might consider submitting cximage as a separate package instead of
>   including it in amsn.  Since Fedora doesn't include cximage already,
>   this won't block the review.
The CxImage supplied with amsn is much different from upstream, and i think not
all patches were accepted so it will stay that way but i am not sure. (I will
check if this is really true)
> 
> * Is there a special reason why the amsn commands (amsn, amsn-remote,
>   amsn-remote-CLI) are located in %{_datadir}/amsn and only linked to
>   %{_bindir}?  Why can't they just be installed directly into %{_bindir}?
Yes, the file perform some magic to see where they are located, and set some
variables accordingly to be able to find plugins etc.
> 
> * Is it necessary to include the %{_datadir}/amsn/lang/missing.py, convert.tcl,
>   and sortlang utilities in the package?
> 
No, language maintainers should use the svn version anyway, so i removed all tools.

http://amsn.hoentjen.eu/download/amsn.spec
http://amsn.hoentjen.eu/download/amsn-0.96-0.9.rc1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.