[Bug 195401] Review Request: osgcal - Adapts OpenSceneGraph to use Cal3D

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: osgcal - Adapts OpenSceneGraph to use Cal3D


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195401


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-06-19 12:10 EST -------
OK, builds on x86_64, development.  rpmlint says:

E: osgcal binary-or-shlib-defines-rpath /usr/bin/osgcal ['/usr/lib64']
W: osgcal-devel no-documentation

The rpath one is a blocker (but no offense to the earlier review comments above;
you'd only see this on an x86_64 machine).  The configure script doesn't seem to
support --disable-rpath, but the usual procedure of adding a BuildRequires:
libtool, adding LIBTOOL=/usr/bin/libtool on the make line, and excluding
%{_libdir}/*.a in the files list seems to work fine.  I'll attach a patch and
assume for the purposes of this review that the patch is applied.  Please do
test to ensure that it doesn't break anything.

Note that 0.1.41 is out currently.  At this point I'm not going to block on it,
but you'll probably want to see if you need to update.

You have a %check section but there doesn't actually seem to be a test suite. 
It's good to be proactive, though.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* source files match upstream:
   4e05fc0ea3320f502d2565a9ac7d2dbb  osgcal-0.1.40.tar.gz
X latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint has only ignorable complaints (ass
* final provides and requires are sane:
  osgcal-0.1.40-1.fc6.x86_64.rpm
   libosgCal.so.0()(64bit)
   osgcal = 0.1.40-1.fc6
  =
   /sbin/ldconfig
   libOpenThreads.so.1()(64bit)
   libProducer.so.1()(64bit)
   libcal3d.so.11()(64bit)
   libgif.so.4()(64bit)
   libglib-2.0.so.0()(64bit)
   libosg.so.1()(64bit)
   libosgCal.so.0()(64bit)
   libosgDB.so.1()(64bit)
   libosgFX.so.1()(64bit)
   libosgGA.so.1()(64bit)
   libosgParticle.so.1()(64bit)
   libosgProducer.so.1()(64bit)
   libosgSim.so.1()(64bit)
   libosgText.so.1()(64bit)
   libosgUtil.so.1()(64bit)
   libxml2.so.2()(64bit)
   libz.so.1()(64bit)

  osgcal-devel-0.1.40-1.fc6.x86_64.rpm
   osgcal-devel = 0.1.40-1.fc6
  =
   cal3d-devel
   libosgCal.so.0()(64bit)
   osgcal = 0.1.40-1.fc6

* shared libraries are present; ldconfig is called properly.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
O %check is present but there doesn't seem to be a test suite to run.
* scriptlets present (ldconfig) are OK.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers present in -devel package.
* pkgconfig files present in -devel package.
* no libtool .la droppings.
* not a GUI app.

APPROVED, conditional on fixing the rpath issue, either with the attached patch
or another method of your choice.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.