[Bug 195394] Review Request: CastPodder

bugzilla at redhat.com bugzilla at redhat.com
Tue Jun 20 03:44:42 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: CastPodder


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195394





------- Additional Comments From kevin at tummy.com  2006-06-19 23:36 EST -------
Excellent progress. 

Builds ok in mock here too. 

Still quite a bit of rpmlint output: 

Why does the package Require python-devel? 

E: CastPodder devel-dependency python-devel

A lot of these: 

E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/es.py "python"

All these localization files as well as some of the contrib files,  
have as the first line: 

#! python

Are they meant to be python scripts? If so, they should be #!/usr/bin/python or
#!/usr/bin/env python or the like. 
If not, perhaps that line should be removed? 

If they are executable they should mode 755: 

E: CastPodder non-executable-script /usr/share/CastPodder/localization/catalog/es.py
0644

Full rpmlint output: 

E: CastPodder devel-dependency python-devel
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/es.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/es.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/en.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/en.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/ca.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/ca.py 0644
E: CastPodder script-without-shellbang /usr/share/CastPodder/updater.py
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/zh-Hans.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/zh-Hans.py 0644
E: CastPodder non-executable-script
/usr/share/CastPodder/ipodder/contrib/GenericDispatch.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/__init__.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/__init__.py 0644
E: CastPodder wrong-script-end-of-line-encoding
/usr/share/CastPodder/localization/catalog/__init__.py
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/pt-BR.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/pt-BR.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/de.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/de.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/it.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/it.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/ko.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/ko.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/el.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/el.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/fi.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/fi.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/nl.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/nl.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/ja.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/ja.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/ru.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/ru.py 0644
E: CastPodder wrong-script-end-of-line-encoding
/usr/share/CastPodder/localization/catalog/ru.py
E: CastPodder non-executable-script
/usr/share/CastPodder/ipodder/contrib/feedparser.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/da.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/da.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/pl.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/pl.py 0644
E: CastPodder wrong-script-end-of-line-encoding
/usr/share/CastPodder/localization/catalog/pl.py
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/gl.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/gl.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/sv.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/sv.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/et.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/et.py 0644
E: CastPodder non-executable-script /usr/share/CastPodder/tools/mkupdate.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/ga.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/ga.py 0644
E: CastPodder non-executable-script /usr/share/CastPodder/tools/purge.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/fr.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/fr.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/sr.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/sr.py 0644
E: CastPodder wrong-script-end-of-line-encoding
/usr/share/CastPodder/localization/catalog/sr.py
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/hu.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/hu.py 0644
E: CastPodder non-executable-script /usr/share/CastPodder/Resources/postflight 0644
E: CastPodder non-executable-script /usr/share/CastPodder/tools/coverage.py 0644
E: CastPodder wrong-script-interpreter
/usr/share/CastPodder/localization/catalog/eu.py "python"
E: CastPodder non-executable-script
/usr/share/CastPodder/localization/catalog/eu.py 0644


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list