[Bug 193896] Review Request: libreadline-java - Java wrapper for the GNU-readline library

bugzilla at redhat.com bugzilla at redhat.com
Thu Jun 22 22:05:10 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libreadline-java - Java wrapper for the GNU-readline library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193896


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




------- Additional Comments From tibbs at math.uh.edu  2006-06-22 17:56 EST -------
Since Hans has offered to sponsor you once a few of your packages are in shape,
I thought I'd take a look at one.  I can't take this for review until you've
been sponsored but I can make some comments.

The package builds fine in mock (x86_64, development) with the reduced
buildroot.    The debuginfo package comes up a bit empty due to the usual rpm
bugs with java; adding the following to the end of the %build section helps, but
you'll want to macroize it to match the rest of the spec:

# Fix debuginfo generation
rm -f org test
ln -s src/org
ln -s src/test

rpmlint has this to say:
W: libreadline-java non-standard-group Development/Libraries/Java
W: libreadline-java no-soname /usr/lib64/libJavaReadline.so.0.8.0
W: libreadline-java devel-file-in-non-devel-package /usr/lib64/libJavaReadline.so
W: libreadline-java-javadoc non-standard-group Development/Java

I'm not sure what's happening with the package groups; Development/Libraries
would seem appropriate unless someone has officially added the Java subgroup
(which wasn't done for the other languages as far as I know.

The unversioned .so file cannot go in the main package; it must go in -devel.

I don't know what's causing the no-soname error; it looks like the upstream
Makefile doesn't call GCC with -Wl,-soname,blah, but I'm not sure if this is a
blocker in this situation.

About the spec:

The gcj_support thing makes things pretty nasty to read; I wonder if it's really
necessary.

Don't set Epoch unless you need it to be a nonzero value.

No need to use an Epoch on the readline Require.

I'm not sure why you need the java_readline and gnu.readline provides.

Don't use Distribution or Vendor.

You need:
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig

instead of Requires: /sbin/ldconfig.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list