[Bug 196393] Review Request: svrcore-devel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: svrcore-devel
Alias: svrcore-devel

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196393


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |panemade at gmail.com




------- Additional Comments From panemade at gmail.com  2006-06-23 01:04 EST -------
Not an official review as I'm not yet sponsored
Mock build for i386 development gave
/var/tmp/rpm-tmp.45547: line 42: /usr/bin/pkg-config: No such file or directory

MUST Items:
     - MUST: rpmlint shows error 
      E: svrcore-devel invalid-spec-name svrcore.spec
     - MUST: dist tag is NOT present
     - MUST: The package is NOT named according to the Package Naming Guidelines.
     - MUST: The spec file name did NOT matching the base package svrcore-devel,
in the format svrcore-devel.spec
      - MUST: This package meets the Packaging Guidelines.
      - MUST: The package is licensed with an open-source compatible license GPL.
      - MUST: The License field in the package svrcore.spec file did NOT match
any license file in tarball.
       - MUST: This package  have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
      - MUST: This package used macros.
      - MUST: No Document files are included in package.
      * Source URL is NOT present.
      * BuildRoot is correct BuildRoot:       
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
      * BuildRequires is NOT correct


You need to do:-
       * Add dist tag to release as
        Release: 1%{?dist}
       * Change SPEC file name to svrcore-devel.spec
       * Add license file in upstream tarball
       * Source is not URL
       * Add pkgconfig in BuildRequires

When i added pkgconfig and check this package in mock still i got some errors
 make EXPORTS= RELEASE= REQUIRES= MODULE= IMPORTS= OBJDIR=. INSTALL=true
syntax error at -e line 3, near "while"
syntax error at -e line 7, near "}"
Execution of -e aborted due to compilation errors.
  I confused here. Can you check whats happening in make that made above error
Though package was built i have not checked in by installing it. First correct
above things and upload new version.
check
http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28packaging%29 for
packaging guidelines
  

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.