[Bug 176253] Review Request: clement-2.1

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clement-2.1


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176253





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-06-26 04:45 EST -------
Sorry for the long silence I've been busy with other Fedora stuff.

As discussed by email I'll review this package and if that goes well I'll
sponsor you.

This isn't a Full Review yet, but this should give you enough for now to work on:
* rpmlint gives:
E: clement non-standard-gid /etc/clement-2.1/clement.conf apache
This is intentional and can be ignored. Are you sure though you want apache to
be able to write to this file, I guess this is for the clement webinterface, but
is this safe?
* During build on FC5-i386 rpm says:
warning: File listed twice: /etc/clement-2.1/clement.conf
warning: File listed twice: /etc/clement-2.1/clement.conf
warning: File listed twice: /var/www/clement-2.1/clembase.php
These must be fixed
* All the files under /var/www are owned by mail, this doesn't seem right
* The files under /var/lib/clement-2.1/ do not seem very variable (except for 
  maybe dummy-cert?), please find a better place for these.
* The remove.sh script called form %preun is evil EVIL *EVIL*, you cannot assume
  that rpm scripts will be run from an interactive terminal. I think it is best
  to just leave these files in place and instead in %preun generate a
  README-fedora in the clement spool dir which explains that since clement is
  removed these files _may_ be removed to, but that they could contain valuable
  data and people should be carefull when removing them. 
* Remove all comments like this one:
#-----------------------------------------------------------
#Clement SPEC definition
#-----------------------------------------------------------
People reading a spec file are supposed to know what a specfile is and what the
different sections do, these are not helpfull comments, they are noise.
* Put the sections in the specfile in the proper order, see for example the
  /usr/share/fedora/spectemplate-minimal.spec from the fedora-rpmdevtools 
  package.
  The proper order is
  Name
  Version
  Release
  Summary
  Group
  ....
  %description

  %setup

  %build
  
  %install

  %clean

  %post(un) (and other scripts)

  %files

  %changelog

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.