[Bug 190007] Review Request: php-pecl-zip

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-zip
Alias: php-pecl-zip

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190007





------- Additional Comments From chris.stone at gmail.com  2006-06-27 17:17 EST -------
MUST ITEM CHECKLIST:
- rpmlint output:
W: php-pecl-zip invalid-license PHP License
W: php-pecl-zip incoherent-version-in-changelog 1.3.0-8.fc5 1.3.1-2.fc5
W: php-pecl-zip invalid-license PHP License
W: php-pecl-zip-debuginfo invalid-license PHP License

Fix Changelog version numbers.  Do not put dist in version numbers unless the
package is specific to that dist only.

The license file warnings are okay to ignore, rpmlint will recognize "PHP
License" in a future release.

- package is named according to php packaging naming guidelines
- spec file name matches %{name}
- package meets packaging guidelines
- package is licensed with open source compatible license
- license field matches actual license
- source does not contain license file
- spec file is in American English (and french)
- spec file is legible
- sources match upstream
d78c8d076b8ced344b3950b1e5299411  zip-1.3.1.tgz
- package successfully compiles and builds on FC-5 x86_64
- All build dependencies are listed in BuildRequires
- package does not use locales
- package does not contain shared libraries in default paths (no need to run
ldconfig)
- package is not relocatable
- package owns all directories it creates
- package does not contain any duplicate %files
- permissions are set properly
- package contains proper %clean section
- macro usage is consistant
- package contains permissible content
- package does not have large documentation
- package does not include header files or static libraries
- package does not use pkgconfig files
- package does not contain library with suffix
- package does not require a devel subpackage
- package does not contain any .la files
- package is not a gui and does not need a .desktop file
- package does not own files or directories owned by other packages

MUST
- Must add Provides: php-pecl(zip)
- Must remove unneeded Requires: zlib

SHOULD
- Investigate what package re2c is used for in this package and determine if it
would be useful to add:
configure: WARNING: You will need re2c 0.9.11 or later if you want to regenerate
 PHP parsers.
- Attach the PHP License file as a source file and include it in %doc
- Use %defattr(-,root,root,-) the defaults are the same

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.