[Bug 189705] Review Request: aiccu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: aiccu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189705





------- Additional Comments From tibbs at math.uh.edu  2006-06-28 12:57 EST -------
Now builds in mock and rpmlint has only the ignorable non-readable error.

The compiler isn't being called with the proper arguments; I see you pass in
RPM_OPT_FLAGS, but that doesn't seem to be used by the Makefiles.  I think
you'll probably have to patch.

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* source files match upstream:
   7c3da5feab3d59fb5a99a45203e0ca56  aiccu_2005.01.31.tar.gz
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint has only ignorable complaints.
* final provides and requires are sane:
   config(aiccu) = 2005.01.31-3.fc6
   aiccu = 2005.01.31-3.fc6
  =
   /bin/sh
   chkconfig
   config(aiccu) = 2005.01.31-3.fc6
   iproute
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.