[Bug 197295] Review Request: perl-List-Compare

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-List-Compare


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197295


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778, 197304              |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-06-29 20:59 EST -------
Note that BuildRequires: perl is redundant; it is part of the default build root.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* source files match upstream:
   205677fa8e207afedbf800673a3c14de  List-Compare-0.33.tar.gz
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(List::Compare) = 0.33
   perl(List::Compare::Accelerated)
   perl(List::Compare::Base::_Auxiliary) = 0.33
   perl(List::Compare::Base::_Engine) = 0.33
   perl(List::Compare::Functional) = 0.33
   perl(List::Compare::Multiple)
   perl(List::Compare::Multiple::Accelerated)
   perl-List-Compare = 0.33-0.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(List::Compare::Base::_Auxiliary)
   perl(List::Compare::Base::_Engine)
   perl(strict) 
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=28, Tests=22945,  4 wallclock secs ( 3.59 cusr +  0.47 csys =  4.06 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.