[Bug 185262] Review Request: kchmviewer - CHM viewer

bugzilla at redhat.com bugzilla at redhat.com
Mon May 1 02:09:22 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kchmviewer - CHM viewer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185262


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          QAContact|fedora-extras-              |fedora-package-
                   |list at redhat.com             |review at redhat.com

jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |jpmahowald at gmail.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2006-04-30 22:09 EST -------
 rpmlint checks return:
E: kchmviewer old-menu-entry /usr/share/applnk/kchmviewer.desktop

Not necessary with it already in /usr/share/applications 

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file ok

%description's a bit long, but oh well.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list