[Bug 190396] Review Request: netpanzer - An Online Multiplayer Tactical Warfare Game
bugzilla at redhat.com
bugzilla at redhat.com
Thu May 4 15:11:19 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: netpanzer - An Online Multiplayer Tactical Warfare Game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190396
j.w.r.degoede at hhs.nl changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andreas at bawue.net
------- Additional Comments From j.w.r.degoede at hhs.nl 2006-05-04 11:11 EST -------
Looking good, the icon installation however is not according to the
freedesktop.org standard.
Please mv netpanzer.png to:
$RPM_BUILD_ROOT%{_datadir}/icons/hicolor/48x48/apps
at the end of %install and update %files accordingly.
You should then also add the following scripts to update the icon cache:
%post
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
%postun
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
These script are described in:
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list