[Bug 191070] Review Request: mcstrans
bugzilla at redhat.com
bugzilla at redhat.com
Tue May 9 23:27:37 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: mcstrans
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191070
------- Additional Comments From dwalsh at redhat.com 2006-05-09 19:27 EST -------
Bad:
- buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)
> Changed to this.
- Source url is 404: http://fedora.redhat.com/projects/mcstrans-0.1.1.tgz
> Not sure where this link should point. We are upstream for this so but I am
not sure where we are supposed to put these tarballs.
- Build fails on both arches, probably a missing BuildRequires:
mcstransd.c:16:29: error: selinux/setrans.h: No such file or directory
> Fixed
Should be fixed:
- Mix of variables like $RPM_BUILD_ROOT and %{optflags}. One method should be
consistant throughout
> Fixed
I updated the tarball and spec file on
http://devserv.devel/~dwalsh/SELinux
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list