[Bug 191111] Review Request: perl-Test-Cmd - Perl module for portable testing of commands and scripts

bugzilla at redhat.com bugzilla at redhat.com
Wed May 10 15:37:07 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Cmd - Perl module for portable testing of commands and scripts


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191111


cweyl at alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From cweyl at alumni.drew.edu  2006-05-10 11:36 EST -------
MUSTS:

- rpmlint checks return nothing (good)
- package meets naming guidelines
- package meets packaging guidelines
- license (Perl: GPL or Artistic) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Looks good by me.  APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list