[Bug 190878] Review Request: childplay_plugins - Plugins for childsplay (educational games for young children)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: childplay_plugins - Plugins for childsplay (educational games for young children)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190878


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-05-10 20:30 EST -------
Since rawhide is borked right now I haven't been able to test mock builds, which
is also how I verify the BR: on packages.  I'll get to that as soon as rawhide
is working again.

MUST
====
* rpmlint output clean
* GPL license ok
* Spec file legible and in Am. English
* Upstream source used during review
  d3ea05d2a1fb373d9c4836845b199a76  childsplay_plugins-0.80.7.tgz
* $RPM_BUILD_ROOT cleaned correctly
* No -devel package needed
* No shared libs
* No locales
* No need for -docs subpackage
* No .desktop file needed

MUSTFIX
=======

* Source0: url points to the Sourceforge mirror selection page.  Better
  to use dl.sourceforge.net or hardcode a mirror so that tools like
  spectool can be used to download the source files. (the same is true for
childsplay, which I failed to notice earlier)

* 'yum remove childsplay childsplay_plugins' left two dangling directories
  on the filesystem:
      - /usr/share/childsplay/plugins
      - /usr/share/childsplay/Data/icons
  This is because yum removed childsplay before childsplay_plugins, and since
  the directories weren't empty when childsplay was removed, and they weren't
  owned by childsplay_plugins, they got left behind.

SHOULD
======
* Even though upstream uses an underscore in the name, I think it's better
  to use a dash '-' here.

* Request that upstream include the GPL license file in the tarball as they
  already do for the base childsplay package.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.