[Bug 187622] Review Request: cowbell

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cowbell


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187622





------- Additional Comments From bdpepple at ameritech.net  2006-05-11 11:31 EST -------
MD5Sums:
fcf32bcf60be2ca204519192eb26bacc  cowbell-0.2.7.1.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* All desired features are enabled
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Package installs and uninstalls cleanly on FC5

Bad:
* Missing scriptlets for GTK+ icon cache.
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d
* Missing Requires for mono-core & gtk-sharp2

Minor:
* Why package the static lib? Pass the --disable-static flag to configure, and
remove '%{_libdir}/cowbell/libtaglibsharpglue.a' from your files.
* Unnecessary BR on gettext.  This is included in the minimum build environment
in Mock.
* I would drop the ChangeLog from the docs, since the NEWS file basically
contains the same info.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.