[Bug 191218] Review Request: PyScript - Postscript graphics with Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyScript - Postscript graphics with Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191218


tjikkun at xs4all.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tjikkun at xs4all.nl




------- Additional Comments From tjikkun at xs4all.nl  2006-05-11 15:46 EST -------
My first review, and i am not a sponsor

I will just list some of the things you probably want to fix:
- BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
- n)
- Specfile should be in the format %{name}.spec
- Package is marked as relocatable, is that really needed? It probably isn't so
that has to be fixed (get rid of Prefix). If it really is necessary you need to
explain why.
- some paths are not replaced with RPM macros
- The BuildRoot must be cleaned at the beginning of %install (add rm -rf
$RPM_BUILD_ROOT)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.