[Bug 191110] Review Request: perl-Devel-Cover - Code coverage metrics for Perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Devel-Cover - Code coverage metrics for Perl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191110





------- Additional Comments From tibbs at math.uh.edu  2006-05-12 00:16 EST -------
rpmlint complains:

W: perl-Devel-Cover doc-file-dependency
/usr/share/doc/perl-Devel-Cover-0.55/buildperl perl(lib)

The buildperl script probably shouldn't be executable.

Makefile.PL warns:
Devel::Cover 0.55 has not been tested with perl 5.008008.
but the test suite seems fine.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
follows the Perl specfile template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   6bb9ddcd7a9e4d87c02b8bbea7ad3c4a  Devel-Cover-0.55.tar.gz
   6bb9ddcd7a9e4d87c02b8bbea7ad3c4a  Devel-Cover-0.55.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
X rpmlint is silent.
* final provides and requires are sane.
O shared libraries are present, but they are internal to Perl so ldconfig
doesn't need to be called.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=38, Tests=38, 72 wallclock secs (69.46 cusr +  2.87 csys = 72.33 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.