[Bug 191218] Review Request: PyScript - Postscript graphics with Python

bugzilla at redhat.com bugzilla at redhat.com
Fri May 12 16:46:15 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyScript - Postscript graphics with Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191218





------- Additional Comments From tjikkun at xs4all.nl  2006-05-12 12:46 EST -------
Ok, I had a little bit more time now, sorry for not giving all directions at
once but i am also still learning.
(In reply to comment #4)
A couple of things:
1) %prep section:
make it:
%setup -q
I don't know if this is a must, but I think it becomes easier if you do this.
First of all you have one line in %prep instead of 3, second you can remove a
lot of %{name}-%{version} so the specfile becomes easier to read

2) I read http://fedoraproject.org/wiki/Packaging/Python , you should do that
too. I hinted to replace paths with libdir but in this page you can read about
%{python_sitelib}, use this instead.

3) use wildcards in the %files section, instead of listing all files seperatly
(see the url in 2 for an example)

4) python setup.py install --prefix=$RPM_BUILD_ROOT/usr still has /usr hardcoded

5) time is up again for me, just a general hint that you can find a lot of info
in the fedora extras wiki.

6) don't take everything i say for granted, i could be wrong sometimes so if you
think i might be just say so.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list