[Bug 165311] Review Request: Tiger, security auditing on UNIX systems

bugzilla at redhat.com bugzilla at redhat.com
Sat May 13 12:44:44 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Tiger, security auditing on UNIX systems


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165311





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-05-13 08:44 EST -------
MUST:
=====
* rpmlint output is:
W: tiger conffile-without-noreplace-flag /etc/cron.d/tiger
E: tiger non-standard-dir-perm /var/log/tiger 0700
E: tiger non-readable /etc/tiger/tigerrc 0640
E: tiger zero-length /usr/lib64/tiger/systems/default/suid_list
E: tiger non-readable /etc/tiger/cronrc 0640
E: tiger non-readable /etc/tiger/tiger.ignore 0600
E: tiger zero-length /usr/lib64/tiger/systems/Linux/2/rel_file_exp_list
E: tiger non-standard-dir-perm /var/run/tiger/work 0700
E: tiger non-standard-dir-perm /etc/tiger 0700
W: tiger symlink-should-be-relative /usr/lib64/tiger/tigexp /usr/sbin/tigexp
E: tiger zero-length /usr/lib64/tiger/systems/default/rel_file_exp_list
W: tiger devel-file-in-non-devel-package /usr/lib64/tiger/version.h
W: tiger log-files-without-logrotate /var/log/tiger
Most of these are OK / have a good reason / intentional (also see previous
comments), so they are ok.I
It would be nice if you could fix the symlink though, but that is not a blocker.
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (GPL) ok but license file not included!
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-x86_64
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* no gui -> no .desktop file required


MUST fix:
=========
* Include COPYING in %doc
* Does /usr/lib64/tiger/html actually gets used during execution or are
  those just docs. If they are just docs the html dir should be under %doc
  instead of under /usr/lib64/tiger/
* Remove /usr/share/doc/tiger-3.2.1/tiger_logo* these aren't docs nor are they
  used by any of the docs (no html docs there) if you decide to keep them
  someplace else (or if the moved html docs need them) remove the x permisson
  bits .

Should fix:
===========
* Please remove the:
 "Please adjust your %{_sysconfdir}/tiger/tigerrc before running."
 line from %description. Usage notes do not belong in %description.
 If you want to you can add this to README.fedora. I didn't modify tigerrc
 and it ran fine though.
* Move these 2 lines from %install to %prep replacing buildroot with . :
 #find $RPM_BUILD_ROOT -type d -name CVS | xargs -iX rm -rf "X"
 find $RPM_BUILD_ROOT -type d -name CVS | xargs rm -rf


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list