[Bug 188180] Review Request: qt4: Qt GUI toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qt4: Qt GUI toolkit


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188180





------- Additional Comments From laurent.rineau__fc_extra at normalesup.org  2006-05-13 13:06 EST -------
Having installed the new packages, and done ugly things like
  for f in $(rpm -qlp RPMS/x86_64/qt4-docs-4.1.2-9.x86_64.rpm); do \
     ll $f -d --color=yes; \
  done | less -r
here is my updated review:

** In:
  for i in designer qmake qtconfig ; do
    ln -s ../%{_lib}/%{qt_dirname}/bin/$i %{buildroot}%{_bindir}/${i}4
  done
i think you should add "assistant linguist lupdate moc qm2ts uic rcc".

I agree with your choice, but maybe some other developers would find strange 
that you forgot to symlink their favorite Qt tool.

And you can symlink qt3to4 without changing its name.

** Why a sub-package for qtconfig, actually? Maybe you have a reason.

** pkgconfig file seem to be hardlinked in %{_libdir}/pkgconfig/ (from 
%{qt_dir}/lib/*.pc) instead of being symlinked. Maybe this should be fixed 
(even if I doubt that someone has a mount point for %{_libdir}/qt4).

** rpmlint still complains about a lot of things, among:

W: qt4-devel summary-ended-with-dot Development files for the Qt GUI toolkit.
W: qt4-mysql summary-ended-with-dot MySQL drivers for Qt's SQL classes.
W: qt4-odbc summary-ended-with-dot ODBC drivers for Qt's SQL classes.
W: qt4-postgresql summary-ended-with-dot PostgreSQL drivers for Qt's SQL 
classes.
W: qt4-sqlite summary-ended-with-dot SQLite drivers for Qt's SQL classes.

Easy fix.

E: qt4-devel invalid-directory-reference /usr/lib64/pkgconfig/QtNetwork.pc
E: qt4-devel invalid-directory-reference /usr/lib64/pkgconfig/QtSvg.pc
E: qt4-devel invalid-directory-reference /usr/lib64/pkgconfig/QtTest.pc
E: qt4-devel invalid-directory-reference /usr/lib64/pkgconfig/Qt3Support.pc
E: qt4-devel invalid-directory-reference /usr/lib64/pkgconfig/QtSql.pc
E: qt4-devel invalid-directory-reference /usr/lib64/pkgconfig/QtGui.pc
E: qt4-devel invalid-directory-reference /usr/lib64/pkgconfig/QtXml.pc
E: qt4-devel invalid-directory-reference /usr/lib64/pkgconfig/QtCore.pc
E: qt4-devel invalid-directory-reference /usr/lib64/pkgconfig/QtOpenGL.pc

Still -L%{_buildir}/qt-x11-opensource-src-4.1.2/lib in pkg-config files. sed 
can fix that.

W: qt4-docs dangling-relative-symlink /usr/lib64/qt4/LICENSE.GPL 
doc/LICENSE.gpl

It is a new item. I have seen this link in the spec file. I do not understand.

** Two minor items of my first review are still left without answer:
  - The /etc/ld.so.conf.d stuff is not really clear. /etc/ld.so.conf.d is 
requires by FC qt on FC-4 and FC-5. And I doubt that qt4 could be accepted for 
previous versions of FC. Perhaps you should simplify your spec file by 
assuming that /etc/ld.so.conf.d/ is required.
  - Your spec file use both %{buildroot} and $RPM_BUILD_ROOT. According to 
http://fedoraproject.org/wiki/Packaging/Guidelines#UsingBuildRootOptFlags you 
should avoid to mixe the two forms.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.