[Bug 190040] Review Request: hydrogen - Advanced drum machine
bugzilla at redhat.com
bugzilla at redhat.com
Sat May 13 23:50:59 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: hydrogen - Advanced drum machine
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190040
------- Additional Comments From green at redhat.com 2006-05-13 19:50 EST -------
Thanks for the review. Updated bits here...
Spec URL: http://people.redhat.com/green/FE/FC5/hydrogen.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/hydrogen-0.9.3-4.src.rpm
(In reply to comment #3)
> [wrt 0.9.3-2]
>
> * FE-NEEDSPONSOR blocker bug is for new contributors who don't have CVS
> access yet. You don't belong to that group anymore.
Ah.. I thought sponsorship applied to packages, not people. Thanks for clearing
this up.
> * Fails to build (FC5), due to a hardcoded -lxml2 in configure{.in}.
>
> /usr/bin/ld: cannot find -lxml2
> collect2: ld returned 1 exit status
>
> Missing: BuildRequires: libxml2-devel
Fixed.
> * From the build log:
>
> | --- Checking for PortAudio -------------------------------------
> | checking whether PORTAUDIOPATH environment variable is set...
> | PORTAUDIOPATH is not set. No PortAudio support.
> | -----------------------------------------------------------------
>
> PortAudio is available in Extras. Should it be enabled?
No, I don't think so. jack is the audio driver of choice for these kinds of apps.
> * rpmlint hydrogen-0.9.3-2.i386.rpm
> E: hydrogen shared-lib-without-dependency-information
> /usr/lib/hydrogen/plugins/wasp_noisifier.so
> E: hydrogen shared-lib-without-dependency-information
> /usr/lib/hydrogen/plugins/wasp_booster.so
> E: hydrogen shared-lib-without-dependency-information
> /usr/lib/hydrogen/plugins/wasp_xshaper.so
> E: hydrogen script-without-shellbang /usr/share/applications/hydrogen.desktop
>
> The first three are safe to ignore. The latter is not. .desktop file is
> executable. The review guidelines say it must be installed with
> desktop-file-install.
Fixed. I've also added related post and postun scripts.
> * The explicit Requires on package names are not good. Kill them and
> rely on rpmbuild's automatic dependencies on SONAMES.
Fixed.
> * The hardcoded Qt version is not good. Source /etc/profile.d/qt.sh
> which sets QTDIR correctly. Further, since many Qt configure checks
> fail due to multilib locations, set QTLIB/QTINC like this:
Cool. Fixed.
Thanks for spending time on this!
AG
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list