[Bug 186887] Review Request: libnetfilter_conntrack - Netfilter conntrack userspace library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnetfilter_conntrack - Netfilter conntrack userspace library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186887


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |kevin at tummy.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-05-13 21:40 EST -------
In answer to comment #2:

Each package must go through a review. ;)

And here is one for this package:

See below - Rpmlint output.
OK - Package name.
OK - Spec file name matches.
OK - Package guidelines.
OK - Licsense.
OK - License field matches in spec.
OK - License included in files
OK - Spec in american english
OK - Spec legible
OK - Md5sum of source from upstream
e07f3d159a869900fbf23f5df12aaf3e  libnetfilter_conntrack-0.0.30.tar.bz2
e07f3d159a869900fbf23f5df12aaf3e  libnetfilter_conntrack-0.0.30.tar.bz2.1

OK - Compiles and builds on one arch at least.
(builds in mock on fc5)
OK - Excludearch not needed
OK - Forbidden buildrequires not included
OK - All required buildrequires included
OK - Ldconfig in post/postun if including libs.
OK - Owns all directories it creates.
OK - No duplicate files in %files listing.
OK - Permissions on files correct.
OK - Clean section correct.
OK - Macros consistant.
OK - Code not content.
OK - Docs must not affect runtime.
OK - Header files/libs in a devel package.
OK - .so files in devel package.
OK - Devel package requires base package.
OK - No .la files.
OK - Doesn't own any files/dirs that are already owned by others.

1. One rpmlint warning:

W: libnetfilter_conntrack-devel summary-not-capitalized netfilter conntrack
userspace library

Suggest: Change the devel summary to "Netfilter conntrack userspace library
development files"

Looks good. If you could fix up the rpmlint warning when you import
into CVS that would be great.

This package is APPROVED.
Don't forget to close this bug when you have imported and built the package.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.