[Bug 189010] Review Request: pybaz - Python library bindings for the GNU Arch/Bazaar RCS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pybaz - Python library bindings for the GNU Arch/Bazaar RCS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189010


orion at cora.nwra.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |orion at cora.nwra.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From orion at cora.nwra.com  2006-05-15 13:15 EST -------
Good -

- package name matches guidelines
- spec is clean/legible
- License is good, matches source.
- owns dirs.
- builds in mock on devel.

Must fix:

- Add COPYING to %doc
- Drop unneeded python-devel BR.

Trouble:

- My mock for FC5 is pulling in epydoc-2.1-2.i386 rather than
epydoc-2.1-4.noarch, and make doc fails with the former but works with the
latter.  I think we'll need to get the repo fixed before a fc5 build works. 
I'll post a message to the FE list about it.

Question:

- Get the following output during make doc devel.  Not sure if it causes any
problems though:

make doc
rm -rf html
mkdir ,,make-doc || exit 1
cp -al pybaz ,,make-doc
rm -rf ,,make-doc/pybaz/tests
cd ,,make-doc ; ../mypydoc --docformat "restructuredtext en" --no-private pybaz
Importing 15 modules.
  [.........
Error importing 'pybaz.backends.knotted': No module named twisted.internet
......]
Building API documentation for 14 modules.
  [./usr/lib/python2.4/site-packages/epydoc/markup/restructuredtext.py:174:
DeprecationWarning: docutils.utils.Reporter.set_conditions deprecated; set
attributes via configuration settings or directly
  document.reporter.set_conditions('', 10000, 10000, None)
===========================================================================
In pybaz.ArchSourceTree.iter_inventory docstring:
---------------------------------------------------------------------------
     - Warning: @keyword used for explitict parameter source
     - Warning: @keyword used for explitict parameter precious
     - Warning: @keyword used for explitict parameter backups
     - Warning: @keyword used for explitict parameter junk
     - Warning: @keyword used for explitict parameter unrecognized
     - Warning: @keyword used for explitict parameter trees
     - Warning: @keyword used for explitict parameter directories
     - Warning: @keyword used for explitict parameter files
     - Warning: @keyword used for explitict parameter both
     - Warning: @keyword used for explitict parameter limit

===========================================================================
In pybaz.WorkingTree.commit docstring:
---------------------------------------------------------------------------
     - Warning: @keyword used for explitict parameter version
     - Warning: @keyword used for explitict parameter log
     - Warning: @keyword used for explitict parameter strict
     - Warning: @keyword used for explitict parameter seal
     - Warning: @keyword used for explitict parameter fix
     - Warning: @keyword used for explitict parameter out_of_date_ok
     - Warning: @keyword used for explitict parameter file_list

===========================================================================
In pybaz.WorkingTree.iter_commit docstring:
---------------------------------------------------------------------------
     - Warning: @keyword used for explitict parameter version
     - Warning: @keyword used for explitict parameter log
     - Warning: @keyword used for explitict parameter strict
     - Warning: @keyword used for explitict parameter seal
     - Warning: @keyword used for explitict parameter fix
     - Warning: @keyword used for explitict parameter out_of_date_ok
     - Warning: @keyword used for explitict parameter file_list

===========================================================================
In pybaz.WorkingTree.undo docstring:
---------------------------------------------------------------------------
     - Warning: @keyword used for explitict parameter revision
     - Warning: @keyword used for explitict parameter output
     - Warning: @keyword used for explitict parameter quiet
     - Warning: @keyword used for explitict parameter throw_away

.............]
Writing HTML docs (100 files) to 'html'.
  [  1%] ............................................................
  [ 61%] ........................................
Warning: Failed identifier crossreference targets:
    - file.next (from pybaz.backends.forkexec.exec_safe_iter_stdout.next)
    - file.readline (from pybaz.backends.forkexec.exec_safe_iter_stdout.next)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.