[Bug 183912] Review Request: jack-audio-connection-kit - The Jack Audio Connection Kit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jack-audio-connection-kit - The Jack Audio Connection Kit


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183912





------- Additional Comments From seg at haxxed.com  2006-05-16 06:40 EST -------
MUST items:

- rpmlint: Ok

$ rpmlint jack-audio-connection-kit-example-clients-0.101.1-6.fc5.i386.rpm
W: jack-audio-connection-kit-example-clients no-documentation

Ignorable.

- Package name: Ok
- Spec name: Ok
- Meets packaging guidelines: Ok
- License: NEEDSWORK
- Spec in American English: Ok
- Spec legible: Ok
- Sources match upstream: Ok
- Builds: Ok
- BuildRequires: Ok
- Locales: Ok
- ldconfig: Ok
- Relocation: Ok
- Directory ownership: Ok
- %files: Ok
- %clean: Ok
- Macros: Ok
- Code vs. Content: Ok
- Documentation: Ok
- devel package: Ok
- .desktop file: n/a

SHOULD:

- Includes license text: Yes
- Spec translations: Ok?
- Mock build: Yes
- Builds on all archs: Builds on i386, x86_64
- Package functional: Tested on i386, x86_64
- Scriptlets: Ok
- Subpackages: Ok

NEEDSWORK:

jack is part GPL and part LGPL. The License: line should probably be set to GPL/LGPL

--enable-shared isn't really necessary, it should be default.

You should add a -p flag to the line that copies README.Fedora, to preserve the
timestamp as advised in the packaging guidelines.

I notice in the main package there is:

%dir %{_libdir}/jack

And in the devel package:

%{_includedir}/jack

Which seems inconsistent. I remember reading a discussion somewhere about the
subtleties of directories, but I forget the details. Near as I can tell the
directories are properly owned in both, is there a difference?  I would get rid
of the %dir tag unless there's a reason for it I'm not aware of. And its also a
good idea to put trailing slashes on directories in %files, to make it more
apparent its specifying a directory.

Fix these minor issues and this package is approve-able in my opinion. I am not
a sponsor so I can't give final approval. Or sponsor. ;P

Okay so its now 5:45am the next day. I'm going to bed. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.