[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs
bugzilla at redhat.com
bugzilla at redhat.com
Wed May 17 00:05:16 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191624
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-05-16 20:05 EST -------
Module::Build is still having trouble in development; I'll review this on FC5.
(We really should try to help Steve with that.)
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible. It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
b22cb4575d910bb2d36e506a958da300 Test-Expect-0.30.tar.gz
b22cb4575d910bb2d36e506a958da300 Test-Expect-0.30.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (FC5, x86_64), with perl-Expect and perl-Expect-Simple
added.
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
All tests successful.
Files=1, Tests=18, 0 wallclock secs ( 0.08 cusr + 0.04 csys = 0.12 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
APPROVED, but note that you won't be able to build on the development branch
until the Module::Build problem gets worked out.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list