[Bug 191239] Review Request: qjackctl - Qt based JACK control application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qjackctl - Qt based JACK control application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191239





------- Additional Comments From seg at haxxed.com  2006-05-17 03:36 EST -------
MUST items:

- rpmlint: Clean
- Package name: Ok
- Spec name: Ok
- Meets packaging guidelines: NEEDSWORK
- License: Ok
- Spec in American English: Ok
- Spec legible: Ok
- Sources match upstream: Ok
- Builds: Ok
- BuildRequires: Ok
- Locales: Ok
- ldconfig: Ok
- Relocation: Ok
- Directory ownership: Ok
- %files: Ok
- %clean: Ok
- Macros: Ok
- Code vs. Content: Ok
- Documentation: Ok
- devel package: Ok
- .desktop file: Ok

SHOULD:

- Includes license text: Ok
- Mock build: Ok
- Builds on all archs: Built on i386, x86_64
- Package functional: Tested on i386, x86_64
- Scriptlets: Ok
- Subpackages: Ok

NEEDSWORK:

Source: seems to need to be http://dl.sf.net/sourceforge/qjackctl/[...] 
otherwise I get a 404 as is.

The Requires: jack-audio-connection-kit >= 0.80.0  is unnecessary as no such old
version is going to be in Extras.

The generic INSTALL instructions should not be packaged.

The desktop file should be included as Source:, not embedded in the spec, as
shown in the Desktop Files section of the packaging guidelines.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.