[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux

bugzilla at redhat.com bugzilla at redhat.com
Tue May 23 17:08:53 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119





------- Additional Comments From wart at kobold.org  2006-05-23 13:01 EST -------
Ignore my previous build failure on devel.  I had mangled my plib package. 
Here's a formal review:

MUST
====
* rpmlint output clean
* Package named appropriately
* Spec file legible and in Am. English
* Builds and packages on FC-4 x86_64
* Source matches upstream:
  e84ab2748ff1ce5ef11d1d7da5188f8f  tuxkart-0.4.0.tar.gz
* $RPM_BUILD_ROOT cleaned appropriately
* Owns all files that it creates
* GPL license ok, license file included
* No -devel package needed
* No need for -docs subpackage
* No shared libaries
* Not relocatable
* No locale files
* .desktop file installed correctly
* No duplicate %files

MUSTFIX
=======
* BR: ImageMagick doesn't seem to be necessary.
* Replace the offending images per comment #3.  In reply to comment #4, I think
these need to be in a new source tarball so that they aren't in the SRPM either.
 The SRPMS get distributed just like the binary RPMs, so the same rules should
apply to make sure they don't contain questionable material.

SHOULD
======
* aclocal, automake, and autoconf all get run due to inter-build file
  dependencies.  This happens because <subdir>/Makefile.in all depend
  on configure.in, which gets patched during %prep. I suggest adding
  the following at the end of %prep to shave a few seconds off of the
  build time:
    touch aclocal.m4
    touch */Makefile.in



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list