[Bug 189088] Review Request: knemo Network monitor applet.
bugzilla at redhat.com
bugzilla at redhat.com
Thu May 25 16:30:15 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: knemo Network monitor applet.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189088
rdieter at math.unl.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rdieter at math.unl.edu
------- Additional Comments From rdieter at math.unl.edu 2006-05-25 12:22 EST -------
A couple of suggestions:
1) Since configure includes:
checking for ifconfig... /sbin/ifconfig
checking for iwconfig... /sbin/iwconfig
You'd best add:
# /sbin/iwconfig
BuildRequires: wireless-tools
# /sbin/ifconfig
BuildRequires: net-tools
2. per the README:
IMPORTANT: KNemo is not an executable but an KDED service. Therefore
it has to be started using Control Center/KDE Components/Service Manager.
As such, this pkg probably ought to
Requires: kdebase
3. .desktop files
The categories are already properly set, the only one you should add is
--add-category=X-Fedora
(else it might accidentally show up in Gnome's menus somewhere).
4. unowned %{_datadir}/apps/knemo, in %files, change
%{_datadir}/apps/knemo/eventsrc
to
%{_datadir}/apps/knemo
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list