[Bug 185951] Review Request: amsn : msn messenger clone

bugzilla at redhat.com bugzilla at redhat.com
Thu May 25 17:47:56 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: amsn : msn messenger clone


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951





------- Additional Comments From wart at kobold.org  2006-05-25 13:40 EST -------
I took a look at Amsn_BWidget to see what the changes are, and they don't seem
very major to me.  Hopefully upstream will agree and accept the changes.

* Some documentation and image updates
* improvements to the font selector to allow disabling the font color, size, and
style
* Some minor widget layout changes (reordering buttons, changing borderwidths)
* New methods in the scrolledwidget for resizing
* A handful of modified RCS strings on otherwise-unmodified files

But I don't understand the reasoning behind a couple of the changes:

* Removal of -background setting in scrolledwindow
* The extra rename of ::$path:cmd in widget.tcl

A possible alternative is to include only the modified files in Amsn_BWidget,
and rely on the FE bwidget package for all of the rest:

  # Pull the base BWidget from FE
  package require BWidget

  # Pull in only the modified files from Amsn
  package require Amsn_BWidget

This might take some work to do right (hacking the pkgIndex.tcl file, probably),
but should allow you to use modified BWidget files without including the entire
BWidget library in amsn.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list