[Bug 193157] Review Request: system-config-selinux

bugzilla at redhat.com bugzilla at redhat.com
Fri May 26 15:37:41 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: system-config-selinux


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193157





------- Additional Comments From paul at city-fan.org  2006-05-26 11:29 EST -------
(In reply to comment #4)
> One would wager that rpm macros need to be updated for %makeinstall if it is not
> 'modern' enough.

Not sure that's good idea. Most packages will work with either approach, but
some will depend on the way one or the other works, and will fail with the
alternative approach.

> The previous spec had:
> 
> Requires: gnome-python2, pygtk2, pygtk2-libglade, gnome-python2-canvas
> Requires: policycoreutils
> Requires: rhpl >= 0.148.2 usermode
> Requires: python >= 2.3

I wonder if it was a good idea to remove these since none of these deps (even
the python(abi) = 2.4 dep that I'd expect) have been found automatically by rpm.

> These have been removed, but the version wasn't updated, nor was made mention
> that this change had happened.

Hmm, not good. Please update the release tag whenever a change is made to the
package, so it's easy to tell which comments refer to which version of the package.




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list